Draft: TXT2KG w/ hotpot_qa.py and tech_qa.py examples
#9846
Conversation
puririshi98
changed the title
w/ hotpot_qa.py` example for precision estimationTXT2KG w/ hotpot_qa.py example for precision estimation
|
@Kh4L reviews welcome |
improve #9846 --------- Co-authored-by: riship <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Great work! 🚀 I may have missed some past PRs that were already merged, but I'm sharing my thoughts here anyway :)
I think we might want to make sure that anything goes under torch_geometric/ is general enough, well documented, well tested so that it's reusable by users outside these example scripts. If these utils under torch_geometric/ are not general enough, users might end up copying the code into their own scripts instead of directly relying on torch_geometric/.
If the intention is for these LLMs+GNNs additions to serve as reference implementations (that users can tweak as needed), it'd make more sense to include them as examples rather than integrating them into torch_geometric/.
|
"I think we might want to make sure that anything goes under torch_geometric/ is general enough, well documented, well tested so that it's reusable by users outside these example scripts" I totally agree btw, this is still a draft. i aim to have full docstrings etc and polish this up once its ready, just wanted an initial review. i will circle back when it is fully ready still have further work to get done before im ready |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (21.60%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #9846 +/- ##
==========================================
+ Coverage 85.86% 85.93% +0.06%
==========================================
Files 490 492 +2
Lines 32432 32621 +189
==========================================
+ Hits 27847 28032 +185
- Misses 4585 4589 +4 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
…eometric into rebase-txt2kg
for more information, see https://pre-commit.ci
…eometric into rebase-txt2kg
for more information, see https://pre-commit.ci
…eometric into rebase-txt2kg
for more information, see https://pre-commit.ci
…eometric into rebase-txt2kg
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…eometric into rebase-txt2kg
rebased #9728