Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exphormer Implementation #9783

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Exphormer Implementation #9783

wants to merge 19 commits into from

Conversation

phoeenniixx
Copy link

Implementing Exphormer based on this paper

See also #9751

pre-commit-ci bot and others added 17 commits November 13, 2024 17:36
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d29c887 
for more information, see https://pre-commit.ci
@phoeenniixx
adding some exception handling to pass pytest
e2e9b68
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fd86ec0 
for more information, see https://pre-commit.ci
@phoeenniixx
Update local.py
8d64b44
@phoeenniixx
solving pytest maybe
f9c7e95
@phoeenniixx
Update test_exphormer.py
603f5c1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f7b64b6 
for more information, see https://pre-commit.ci
@phoeenniixx
Update CHANGELOG.md
a2b58f8
@phoeenniixx
pre-commit issue
4ae11a5
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a50a0e5 
for more information, see https://pre-commit.ci
@phoeenniixx
pre-commit
86508cc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4981d8c 
for more information, see https://pre-commit.ci
@phoeenniixx
Update test_exphormer.py
9f874c4
@phoeenniixx
trying solving linting error
fb1516d
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
39316ff 
for more information, see https://pre-commit.ci
@phoeenniixx
adding annotations
abccb11
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
ebd2bf3 
for more information, see https://pre-commit.ci
@phoeenniixx
Copy link
Author

phoeenniixx commented Nov 15, 2024 •
edited
Loading

Hi @rusty1s, @xnuohz, @wsad1, @EdisonLeeeee, I think this PR is now ready for review
Sorry it took a while to understand the coding standards here😅
Now only the linting and documentation build is failing, I tried solving the linting issue but when I added annotations, it now shows new errors, please can you give me a little debrief on what are the standards...

Thanks in advance!

@phoeenniixx
Copy link
Author

Hi @rusty1s, @xnuohz, @wsad1, @EdisonLeeeee, I think the PR is ready to review, all conflicts are resolved!!

@phoeenniixx
Copy link
Author

Hi @rusty1s, @xnuohz, @wsad1, @EdisonLeeeee, please provide an ETA for review...

@xnuohz xnuohz mentioned this pull request Dec 30, 2024
Open
@xnuohz
Copy link
Contributor

xnuohz commented Dec 30, 2024

Hi, @phoeenniixx I just submitted a PR for SGFormer. You can check it and determine how your work could be better integrated into torch_geometric. Like but not limited

  • Your test cases are a little complicated
  • Add an example for training a model on a special dataset and log the metrics
  • ...
    Thanks:)

@phoeenniixx
Copy link
Author

Thanks for the reply @xnuohz, been a little busy lately, I will make the changes in few days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature nn transform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phoeenniixx @xnuohz @akihironitta