Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add figure for navigating help resources #9147

Merged
merged 16 commits into from
Jun 24, 2024

Conversation

JessicaS11
Copy link
Contributor

@JessicaS11 JessicaS11 commented Jun 20, 2024

@max-sixty
Copy link
Collaborator

Very cool! Thanks @JessicaS11

Couple of suggested changes (maybe others will disagree, I see a draft of this was reviewed in the discussion):

  • Can we add a line directly from having a bug or type to PR? No need for folks to open an issue for something small.
  • Possibly PRs should be inside the contributions box?
  • Add LLMs as an option in "How do I use Xarray"?
  • I actually don't think it's helpful to ping issues. PRs are waiting on maintainers, but issues need contributions not reminders, so I'd remove that arrow.
    • Pinging can just be "Gentle ping", no need to @ an individual (and not sure how they'd know who to @...)

@JessicaS11
Copy link
Contributor Author

Readthedocs is failing with: fatal: reference is not a tree for the last commit. I'm assuming this is somehow caused by the way I added to the PR, but I'm also not sure how to fix it. To add to the PR after the precommit.ci commit, I ran git fetch upstream pull/9147/head:help-figup and git rebase db637420 before git push origin help-fig:help-fig. Is there another way to do this that won't upset readthedocs?

@keewis
Copy link
Collaborator

keewis commented Jun 20, 2024

looks like that was just a temporary hiccup: https://readthedocs.org/projects/xray/builds/24763397/

@JessicaS11
Copy link
Contributor Author

JessicaS11 commented Jun 20, 2024

Couple of suggested changes (maybe others will disagree, I see a draft of this was reviewed in the discussion):

Thanks for sharing these - I'll commit once I've addressed them all.

* Can we add a line directly from having a bug or type to PR? No need for folks to open an issue for something small.

I'll update these

* Possibly PRs should be inside the contributions box?

Good call!

* Add LLMs as an option in "How do I use Xarray"?

Done!

* I actually don't think it's helpful to ping issues. PRs are waiting on maintainers, but issues need contributions not reminders, so I'd remove that arrow.

I guess I was thinking the case where the issue is a proposal that needs "approval" or feedback for the contributor to work on and get to the point of submitting a PR. Bug report issues aren't generally going to be "quiet" because maintainers are likely to be working on fixing them.

  * Pinging can just be "Gentle ping", no need to @ an individual (and not sure how they'd know who to @...)

What is a "gentle ping" then? Simply posting a comment in the PR?

@max-sixty
Copy link
Collaborator

What is a "gentle ping" then? Simply posting a comment in the PR?

Sorry, yes, I'm not sure the best wording, I was thinking fab:fa-github Gentle ping! might be a nice informal way of showing it, but maybe that's confusing, feel free to riff...

I guess I was thinking the case where the issue is a proposal that needs "approval" or feedback for the contributor to work on and get to the point of submitting a PR. Bug report issues aren't generally going to be "quiet" because maintainers are likely to be working on fixing them.

IME it's quite rare that things need approval to get started, at least in projects like xarray. And there are almost 1000 issues so pinging for updates is somewhat disruptive.

So I would probably:

  • add an arrow from the root to contributors' guide "I'd like to make a small change"
  • drop the "my plan was approved"
  • switch "I found a bug or typo" -> "I found a bug"

Is that OK? I don't mean to be wordsmithing. (It's actually quite interesting to have to make legible lots of implicit understanding of how to operate.)

@JessicaS11
Copy link
Contributor Author

Is that OK? I don't mean to be wordsmithing. (It's actually quite interesting to have to make legible lots of implicit understanding of how to operate.)

It's great - I completely agree on the making explicit the implicit being an interesting exercise.

I went with "Comment on your PR" - to me a "ping" means an @ mention or Slack/email message (basically explicitly contacting a group or individuals), which I'm sure is one of many definitions people have for it!

@max-sixty
Copy link
Collaborator

I think this is looking really good! Thanks @JessicaS11 !

@JessicaS11
Copy link
Contributor Author

I think this is looking really good! Thanks @JessicaS11 !

Thanks! I'm going to see if I can get it to render properly in the docs before merging (hence ongoing changes). Right now it's building successfully but showing up as text...

@JessicaS11
Copy link
Contributor Author

Hey team - I'm hitting a wall here on how to get this rendered. Specifically, it appears the sphinxcontrib.mermaid extension uses an older version of mermaid (10.2.0) than the mermaid.live editor I used to create the flowchart (10.9.1). As a result, there are syntax errors. My understanding of the solution pathways are:

  1. get the current flowchart code to work in an older version of Mermaid (not sure of an easy way to do this).
  2. build the diagram and include it in the docs differently (e.g. using mermaid-cli), which I don't understand how things are built under the hood well enough to execute on my own (see also my attempt to get such a figure into the xarray-tutorial, though there was discussion of moving that to the docs as well: update backends tutorials intro xarray-contrib/xarray-tutorial#266)

Any help or insight is greatly appreciated!

@dcherian
Copy link
Contributor

I found a setting to set a custom mermaid version: https://sphinxcontrib-mermaid-demo.readthedocs.io/en/latest/#config-values

@JessicaS11
Copy link
Contributor Author

JessicaS11 commented Jun 24, 2024

I found a setting to set a custom mermaid version: https://sphinxcontrib-mermaid-demo.readthedocs.io/en/latest/#config-values

@dcherian Thank you!!

@JessicaS11 JessicaS11 marked this pull request as ready for review June 24, 2024 15:06
@JessicaS11 JessicaS11 merged commit 56209bd into pydata:main Jun 24, 2024
28 checks passed
@JessicaS11 JessicaS11 deleted the help-fig branch June 24, 2024 15:31
dcherian added a commit to dcherian/xarray that referenced this pull request Jun 28, 2024
* main:
  promote floating-point numeric datetimes to 64-bit before decoding (pydata#9182)
  also pin `numpy` in the all-but-dask CI (pydata#9184)
  temporarily remove `pydap` from CI (pydata#9183)
  temporarily pin `numpy<2` (pydata#9181)
  Change np.core.defchararray to np.char (pydata#9165) (pydata#9166)
  Fix example code formatting for CachingFileManager (pydata#9178)
  Slightly improve DataTree repr (pydata#9064)
  switch to unit `"D"` (pydata#9170)
  Docs: Add page with figure for navigating help resources (pydata#9147)
  Add test for pydata#9155 (pydata#9161)
  Remove mypy exclusions for a couple more libraries (pydata#9160)
  Include numbagg in type checks (pydata#9159)
  Improve zarr chunks docs (pydata#9140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants