Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to not auto-create index during expand_dims #8960

Merged
merged 18 commits into from
Apr 27, 2024
Merged

Option to not auto-create index during expand_dims #8960

merged 18 commits into from
Apr 27, 2024

Commits on Apr 20, 2024

  1. test expand_dims doesn't create Index

    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    3719ba7 View commit details
    Browse the repository at this point in the history

  2. add option to not create 1D index in expand_dims

    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    018e74b View commit details
    Browse the repository at this point in the history

  3. refactor tests to consider data variables and coordinate variables se… 

    …parately
    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    f680505 View commit details
    Browse the repository at this point in the history

  4. fix bug causing new test to fail

    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    f10509a View commit details
    Browse the repository at this point in the history

  5. test index auto-creation when iterable passed as new coordinate values

    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    8152c0a View commit details
    Browse the repository at this point in the history

  6. make test for iterable pass

    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    aa813cf View commit details
    Browse the repository at this point in the history

  7. added kwarg to dataarray

    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    e78de7d View commit details
    Browse the repository at this point in the history

  8. whatsnew

    @TomNicholas
    TomNicholas committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    b1329cc View commit details
    Browse the repository at this point in the history

  9. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    a9f7e0c View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. update tests to use private versions of assertions

    @TomNicholas
    TomNicholas committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    62e750f View commit details
    Browse the repository at this point in the history

  2. create_1d_index->create_index

    @TomNicholas
    TomNicholas committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f86c82f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into expand_dims_create_1d_index

    @TomNicholas
    TomNicholas committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4dd8d3c View commit details
    Browse the repository at this point in the history

  4. Update doc/whats-new.rst 

    Co-authored-by: Deepak Cherian <[email protected]>
    @TomNicholas @dcherian
    TomNicholas and dcherian authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d5d90fd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. warn if create_index=True but no index created because dimension vari… 

    …able was a data var not a coord
    @TomNicholas
    TomNicholas committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7e8f895 View commit details
    Browse the repository at this point in the history

  2. add string marks in warning message

    @TomNicholas
    TomNicholas committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ed85446 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into expand_dims_create_1d_index

    @TomNicholas
    TomNicholas authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    39571ba View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into expand_dims_create_1d_index

    @TomNicholas
    TomNicholas authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    928dbe9 View commit details
    Browse the repository at this point in the history

  5. fix bad merge

    @TomNicholas
    TomNicholas committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    6bde158 View commit details
    Browse the repository at this point in the history