Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write an empty "coordinates" attribute to a netCDF file #5121

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Do not write an empty "coordinates" attribute to a netCDF file #5121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5ccfaf
Do not write to disk `coordinates` as an empty string
alexamici Apr 6, 2021
bcbfae2
Only remove the empty coordinates attribute if auto-generated + tests
alexamici Apr 6, 2021
039af0b
Simplify logic
alexamici Apr 7, 2021
1cf3c8d
Update xarray/conventions.py
alexamici Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion xarray/conventions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,11 +756,13 @@ def _encode_coordinates(variables, attributes, non_dim_coord_names):
# we get support for attrs["coordinates"] for free.
coords_str = pop_to(encoding, attrs, "coordinates")
if not coords_str and variable_coordinates[name]:
attrs["coordinates"] = " ".join(
coordinates_text = " ".join(
str(coord_name)
for coord_name in variable_coordinates[name]
if coord_name not in not_technically_coordinates
)
if coordinates_text:
attrs["coordinates"] = coordinates_text
if "coordinates" in attrs:
written_coords.update(attrs["coordinates"].split())

Expand Down
2 changes: 1 addition & 1 deletion xarray/tests/test_backends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ def test_grid_mapping_and_bounds_are_not_coordinates_in_file(self):
with open_dataset(tmp_file, decode_coords=False) as ds:
assert ds.coords["latitude"].attrs["bounds"] == "latitude_bnds"
assert ds.coords["longitude"].attrs["bounds"] == "longitude_bnds"
assert "latlon" not in ds["variable"].attrs["coordinates"]
assert "coordinates" not in ds["variable"].attrs
assert "coordinates" not in ds.attrs

def test_coordinate_variables_after_dataset_roundtrip(self):
Expand Down