-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read grid mapping and bounds as coords #2844
Merged
dcherian
merged 40 commits into
pydata:master
from
DWesl:read_grid_mapping_and_bounds_as_coords
Feb 17, 2021
Merged
Changes from 3 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
62152d0
Read and save `grid_mapping` and `bounds` as coordinates.
DWesl 2ae8a7e
Add tests for (de)serialization of `grid_mapping` and `bounds`.
DWesl fff73c8
BUG: Use only encoding for tracking bounds and grid_mapping.
DWesl b3696d3
Address feedback on PR.
DWesl 315d39d
Merge branch 'master' into read_grid_mapping_and_bounds_as_coords
DWesl c82cd47
Merge branch 'master' into read_grid_mapping_and_bounds_as_coords
DWesl 02aff73
Style fixes: newline before binary operator.
DWesl 0721506
Style fixes: double quotes for string literals, rewrap lines.
DWesl 239761e
Address comments from review.
DWesl e0b8e99
Fix style issues and complete name changes.
DWesl 9ba7485
Add more attributes from the CF conventions.
DWesl bf97fe1
Merge branch 'master' into read_grid_mapping_and_bounds_as_coords
DWesl 4274730
Remove a trailing comma in a one-element dict literal.
DWesl ca0f805
Merge branch 'master' into read_grid_mapping_and_bounds_as_coords
DWesl 7027767
Stop moving ancillary_variables to coords
DWesl 8d96a66
Expand the list of attributes in the documentation.
DWesl 1a5b35d
Make sure to run the pip associated with the running python.
DWesl 9f53fbb
Warn about new locations for some variables.
DWesl 1b8218d
Merge branch 'master' into read_grid_mapping_and_bounds_as_coords
DWesl 546b43e
Move ancillary variables back to data_vars in test.
DWesl 8ec4af3
Update warnings to provide a more useful stack level.
DWesl bc0b1d1
Split the CF attribute test into multiple smaller tests.
DWesl 5c085e1
Add a test of a roundtrip after dropping bounds.
DWesl a5a67d1
Merge work from github back into local branch.
DWesl a864b83
Run black on changes.
DWesl c8d1bdc
Check whether round-trip to iris breaks things.
DWesl 478be8a
Remove trailing comma.
DWesl 036695c
Merge branch 'master' into read_grid_mapping_and_bounds_as_coords
DWesl b0e7a85
Style fixes from black.
DWesl 1a9b201
Include suggestions from review.
DWesl 6f3d55e
Update xarray/tests/test_backends.py
DWesl 5268500
Update xarray/conventions.py
DWesl 2edd367
Mention that there are other attributes not listed
DWesl 948465c
Fix .rst syntax in whats-new
DWesl c68d372
Shorten name of another test.
DWesl 9ee7c3a
Update docs.
dcherian b65e579
Merge remote-tracking branch 'upstream/master' into read_grid_mapping…
dcherian 94b8153
fix merge.
dcherian c8896f3
Activate new behaviour only with `decode_coords="all"`
dcherian d3ec7ab
[skip-ci] fix docstrings
dcherian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to supply a default value of
None
with.get()
, that is already the default:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But actually: are there any cases where someone would explicitly have
grid_mapping=None
inencoding
? If not, then let's just check:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. That detail should go in documentation somewhere. Where would you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change is done. Docs change is not. What page should that go on? IO/NetCDF?