-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release notes: 2025.01.2 #10007
base: main
Are you sure you want to change the base?
release notes: 2025.01.2 #10007
Conversation
Todo: fix contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This summary text looks good, but why are there no other entries in the whats-new? Have we become that sloppy at enforcing additions to the release notes in PRs?
I've checked the commit list and added one that was missing already. Several PR's (4 I think) are listed under the non-nanosecond new features entry. @TomNicholas which commits (which are not yet mentioned) should definitely be added to the whats-new? |
Well I don't know about specific commits, but there are new features mentioned in the summary text that don't have whats-new entries, e.g.
|
To be clear I'm not asking you to go back and fish through and add them, but I do think we should be trying harder to actually document all changes as we merge PRs. (Or better yet, have some automated enforcement.) |
That's that one here: Improve the error message raised when no key is matching the available variables in a dataset. (:pull: I've taken the description of the PR instead because it gets better to the point. |
whats-new.rst