Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Revert micromamba version to v2 #805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BLD: Revert micromamba version to v2 #805

wants to merge 1 commit into from

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Nov 7, 2024

This PR reverts CI change introduced in #799.

@mtsokol mtsokol self-assigned this Nov 7, 2024
@hameerabbasi hameerabbasi enabled auto-merge (squash) November 7, 2024 11:03
@mtsokol
Copy link
Collaborator Author

mtsokol commented Nov 7, 2024

I think we should merge it once windows job passes, so when mamba-org/setup-micromamba#227 is fixed. WDYT?

@hameerabbasi
Copy link
Collaborator

I think we should merge it once windows job passes, so when mamba-org/setup-micromamba#227 is fixed. WDYT?

SGTM, can't merge it until CI passes anyway. So my recommendation would be to re-run the CI and then merge after a fix.

@mtsokol mtsokol added the build label Nov 7, 2024
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #805 will improve performances by 24.4%

Comparing micromamba-v2 (fbc6c21) with main (9b431e7)

Summary

⚡ 1 improvements
✅ 339 untouched benchmarks

Benchmarks breakdown

Benchmark main micromamba-v2 Change
test_index_slice[side=100-rank=2-format='gcxs'] 3.4 ms 2.7 ms +24.4%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants