FIX - Crash in translator when using a non HTML builder #2142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips the transpator setup if the builder is not targeting
html
as the format.In our readthedocs config, we use
formats: all
which besides HTML also builds PDF using thelatex
builder, causing the following error:This builder has the
default_translator_class
defined, but it is not compatible with theBootstrapHTML5TranslatorMixin
and thus causes theAttributeError
above.This can be prevented by first checking if the builder uses the
html
format, which is true for thehtml
andsinglehtml
builders.Since the builder format does not change and is independent of the translator, it makes sense to lift it out of the loop over translators.