Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptoreader #917

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Cryptoreader #917

wants to merge 25 commits into from

Conversation

SteffenGue
Copy link

@SteffenGue SteffenGue commented Nov 25, 2021

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check pandas_datareader
  • added entry to docs/source/whatsnew/vLATEST.txt

Deleted exchanges without historic-rates request
Refactoring
-More Unit-Tests
-Refactoring
…ng is done.

- Added CryptoReader.check_symbols() to check if the symbols are available at an exchange.
- Bugfix CryptoReader._check_symbols
- Bugfix reset _BaseReader after a complete run.
-Implemented predefined _BaseReader methods.
- Updated requirements
-Bugfix Coinpaprika splitting currency-pairs.
-Currency-pair split now with "/", e.g. btc/usd.
-Bugfix Coinpaprika splitting currency-pairs.
-Currency-pair split now with "/", e.g. btc/usd.
@bashtage
Copy link
Contributor

bashtage commented Dec 3, 2021

Which black are you using? I'm surprised 93 files have been changed.

@SteffenGue
Copy link
Author

Hi @bashtage!

I'm using Black version 19.10b0. Most changes are due to new yaml-files (78 in total), each file represents a cryptocurrency exchange (in the directory crypto_utils/resources/).

Within the already existing Python files, I made changes in the following 3; while 8 more files are added for the CryptoReader to work:

  • pandas_datareader/data.py
  • pandas_datareader/exceptions.py
  • pandas_datareader/init.py

Best!
Steffen

-Fixed splitting parameter for platforms
-New unit tests
-Adjusted parameter order for CryptoReader to match the DataReader
-Listed currency-pair request simplified
-Some small bug fixes
@SteffenGue SteffenGue marked this pull request as ready for review December 25, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants