drop 3.7 support, migrate to ruff format #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml
Outdated
| @@ -42,12 +42,12 @@ classifiers = [ | |||
| 'Framework :: Pytest', | |||
| 'Topic :: Software Development :: Libraries :: Python Modules', | |||
| ] | |||
| requires-python = '>=3.7' | |||
| requires-python = '>=3.8' | |||
| dynamic = ['version'] | |||
| dependencies = [ | |||
| 'pytest>=7', | |||
| 'black>=23', | |||
There was a problem hiding this comment.
i guess you can remove black as a dependency now?
There was a problem hiding this comment.
black_format still exists as a function for now, I want to push that as a follow up PR to keep a smaller diff. "ruff format" in this context is for our CI, not for the functionality 😂
There was a problem hiding this comment.
Actually I'll just add here as a follow-up commit.
pyproject.toml
Outdated
| target-version = 'py38' | ||
|
|
||
| [tool.ruff.format] | ||
| quote-style = "single" |
There was a problem hiding this comment.
Can we use consistent quotes, double quotes would probably better, but we're using single quotes else where
| @@ -205,21 +214,6 @@ def _insert_print_args( | |||
| triple_quotes_prefix_re = re.compile('^ *(?:"{3}|\'{3})', re.MULTILINE) | |||
|
|
|||
|
|
|||
| def find_print_line(lines: list[str], line_no: int) -> int: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of tidying up.
Fixes #26 at the same time.