Add dummy tool call id for models that doesn't return it #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_to_pydantic_tool_call()
…the usage of dummy_tool_call_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #895
Changes
dummy_tool_call_idto_utils.pydummy_tool_call_idinmodels/gemini.pyandmodels/mistral.py, where it was found that tool call id could beNone:dummy_tool_call_id. No tests were added since the updated tests already verify the usage of the dummy id.test_request_tool_call_with_no_id_from_modeltest for Mistral to test usage ofdummy_tool_call_idwhenMistralToolCallhasid == None.