Refactor user tokens, introduce Logfire client #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is guaranteed to be set
Most of the changes are in the `LogfireCredentials` class, where we don't pass in base URLs, tokens and sessions anymore. Any API-only related operations are defined on the new Logfire client, and `LogfireCredentials` now only has the actual functional logic (with user prompts, etc).
Viicos
commented
Apr 3, 2025
Viicos
commented
Apr 3, 2025
alexmojaki
reviewed
Apr 17, 2025
Comment on lines
+70
to
+100
| from .config import PYDANTIC_LOGFIRE_TOKEN_PATTERN, REGIONS | ||
|
|
||
| region = 'us' | ||
| if match := PYDANTIC_LOGFIRE_TOKEN_PATTERN.match(self.token): | ||
| region = match.group('region') | ||
| if region not in REGIONS: | ||
| region = 'us' |
There was a problem hiding this comment.
i think this should be a separate method/function
| return token | ||
|
|
||
| def is_logged_in(self, base_url: str | None = None) -> bool: | ||
| if base_url is not None: |
There was a problem hiding this comment.
The base_url is None case seems weird to me
alexmojaki
reviewed
Apr 17, 2025
Comment on lines
+50
to
+71
| try: | ||
| response = self._get('/v1/organizations') | ||
| except UnexpectedResponse as e: | ||
| raise LogfireConfigError('Error retrieving list of organizations') from e |
There was a problem hiding this comment.
Looks like it should be something like this:
Suggested change
| try: | |
| response = self._get('/v1/organizations') | |
| except UnexpectedResponse as e: | |
| raise LogfireConfigError('Error retrieving list of organizations') from e | |
| response = self._get('/v1/organizations') | |
| LogfireConfigError.raise_for_status(response, 'Error retrieving list of organizations') |
| ) | ||
|
|
||
| def __str__(self) -> str: | ||
| # TODO define in this module? |
Viicos
force-pushed
the
refactor-user-tokens
branch
from
3831bd8 to
22ba035
Compare
Deploying logfire-docs with
|
| Latest commit: |
cf0860f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://01e5e4eb.logfire-docs.pages.dev |
| Branch Preview URL: | https://refactor-user-tokens.logfire-docs.pages.dev |
Viicos
force-pushed
the
refactor-user-tokens
branch
from
22ba035 to
cf0860f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor in preparation of #961.
I'm introducing a Logfire client, so that we can use it in the various
LogfireCredentialsmethods without passing the base URL and session around. A proper user token structure is also introduced (which will also be useful for the whoami command improvements).Early PR before adapting test to get some early feeback.