Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capture_response_text_body to instrument_httpx #747

Merged
merged 8 commits into from
Dec 30, 2024

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Dec 30, 2024

Parts 1 and 5 of #655

Copy link

cloudflare-workers-and-pages bot commented Dec 30, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f51299c
Status: ✅  Deploy successful!
Preview URL: https://5fac72b5.logfire-docs.pages.dev
Branch Preview URL: https://alex-httpx-response-text.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2a232d5) to head (f51299c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #747   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines        10872     10916   +44     
  Branches      1541      1547    +6     
=========================================
+ Hits         10872     10916   +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmojaki alexmojaki marked this pull request as ready for review December 30, 2024 14:30
@alexmojaki alexmojaki changed the title capture_response_text_body Add capture_response_text_body to instrument_httpx Dec 30, 2024
@alexmojaki alexmojaki requested a review from Kludex December 30, 2024 14:31
@alexmojaki alexmojaki merged commit 2379a05 into main Dec 30, 2024
14 checks passed
@alexmojaki alexmojaki deleted the alex/httpx-response-text branch December 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants