Drop rich from logfire inspect (#746)

pydantic · Dec 30, 2024 · 2a232d5 · 2a232d5
1 parent 9f73d99
commit 2a232d5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/logfire/_internal/cli.py b/logfire/_internal/cli.py
@@ -149,11 +149,6 @@ def parse_clean(args: argparse.Namespace) -> None:
 
 def parse_inspect(args: argparse.Namespace) -> None:
     """Inspect installed packages and recommend packages that might be useful."""
-    console = Console(file=sys.stderr)
-    table = Table()
-    table.add_column('Package')
-    table.add_column('OpenTelemetry instrumentation package')
-
     # Ignore warnings from packages that we don't control.
     warnings.simplefilter('ignore', category=UserWarning)
 
@@ -175,26 +170,30 @@ def parse_inspect(args: argparse.Namespace) -> None:
     if packages.get('urllib3') and packages.get('requests'):
         del packages['urllib3']
 
+    # fmt: off
+    sys.stderr.write('The following packages from your environment have an OpenTelemetry instrumentation that is not installed:\n')
+    sys.stderr.write('\n')
+    sys.stderr.write(f' {"Package":<18}| OpenTelemetry instrumentation package\n')
+    sys.stderr.write(f' {"-" * 18}|{"-" * 45}\n')
+    # fmt: on
+
     for name, otel_package in sorted(packages.items()):
         package_name = otel_package.replace('.', '-')
-        import_name = otel_package.replace('-', '_')
-        link = f'[link={BASE_OTEL_INTEGRATION_URL}/{import_name}/{import_name}.html]opentelemetry-instrumentation-{package_name}[/link]'
-        table.add_row(name, link)
-
-    console.print(
-        'The following packages from your environment have an OpenTelemetry instrumentation that is not installed:'
-    )
-    console.print(table)
+        otel_package_name = f'opentelemetry-instrumentation-{package_name}'
+        sys.stderr.write(f' {name:<18}| {otel_package_name}\n')
 
     if packages:  # pragma: no branch
         otel_packages_to_install = ' '.join(
             f'opentelemetry-instrumentation-{pkg.replace(".", "-")}' for pkg in packages.values()
         )
         install_command = f'pip install {otel_packages_to_install}'
-        console.print('\n[bold green]To install these packages, run:[/bold green]\n')
-        console.print(f'[cyan]{install_command}[/cyan]', soft_wrap=True)
-        console.print('\n[bold blue]For further information, visit[/bold blue]', end=' ')
-        console.print(f'[link={INTEGRATIONS_DOCS_URL}]{INTEGRATIONS_DOCS_URL}[/link]')
+        sys.stderr.writelines(
+            (
+                '\nTo install these packages, run:\n',
+                f'\n$ {install_command}\n',
+                f'\nFor further information, visit {INTEGRATIONS_DOCS_URL}\n',
+            )
+        )
 
 
 def parse_auth(args: argparse.Namespace) -> None:

diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -210,8 +210,8 @@ def test_inspect(
 
 
 def packages_from_output(output: str) -> set[str]:
-    pattern = r'│\s*(\w+)\s*│\s*([\w-]+)\s*│'
-    matches = re.findall(pattern, output)
+    pattern = r'^\s*([\w]+)\s*\|\s*([\w\-]+)\s*$'
+    matches = re.findall(pattern, output, re.MULTILINE)
     return {match[1] for match in matches}