Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: double escape problem of MyST-Parser #108

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

shimizukawa
Copy link
Member

fix for #107

MyST-Parser で & を含むURLを二重エスケープしてしまっている問題の修正。

@shimizukawa shimizukawa self-assigned this Sep 13, 2024

def setup(app):
# refs: https://github.com/executablebooks/MyST-Parser/issues/760
base.escapeHtml = lambda s: s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

へー。参考になる。

Comment on lines +7 to +12
return {
'version': '0.1',
'env_version': 1,
'parallel_read_safe': True,
'parallel_write_safe': True,
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takanory
Copy link
Member

プレビューでちゃんと動作していることを確認した

https://wwwpyconjp--108.org.readthedocs.build/policies/internet-policy.html

image

Copy link
Member

@terapyon terapyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

myst_patchという、エクステンションを作って、その中で上書きしているのか。
面白い。


def setup(app):
# refs: https://github.com/executablebooks/MyST-Parser/issues/760
base.escapeHtml = lambda s: s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

へー。参考になる。

@koedoyoshida koedoyoshida merged commit d8338e5 into master Sep 14, 2024
1 check passed
@koedoyoshida koedoyoshida deleted the patch-fix-double-escape branch September 14, 2024 09:37
@koedoyoshida koedoyoshida restored the patch-fix-double-escape branch September 14, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants