Skip to content
This repository was archived by the owner on Sep 10, 2024. It is now read-only.

add HMC5883L driver for 3-Axis Digital Compass IC #6

Closed
wants to merge 6 commits into from

Conversation

livius2
Copy link
Contributor

@livius2 livius2 commented Mar 13, 2017

First version of driver
without compensate, selftest and calibration but good point to start.
Slightly optimized form memory allocation in every m.readAxes()

@Bucknalla
Copy link
Contributor

Looks good! 👍 I'll give this a test when I get back to the office and take a look at the merge conflicts!

@livius2
Copy link
Contributor Author

livius2 commented Mar 14, 2017

You can write somwhere that this is e.g. in popular GY-271 because not all know what is HMC5883L ;-)

@Bucknalla
Copy link
Contributor

Hi @livius2 I've ordered a HMC5883L to test this out! Should arrive Monday - I'll give your code a test and then get it committed into the repo.

@Bucknalla
Copy link
Contributor

Bucknalla commented Mar 26, 2017

Hi @livius2, I'm having trouble getting your lib to run on my GY-271. I'll give it another try on Monday but in the meantime, can you please create a new pull request for just the HMC5883L lib and test script (more the onewire.py to a new pull request)?

Thanks!

Alex

@livius2
Copy link
Contributor Author

livius2 commented May 2, 2017

@alex i do not know how i ommit this message from you
I found it now in my spam e-mail folder

May knowledge about git is strongly limited i do not know how to do separete pull request.
Please contact me directly throught forum chat or by e-mail.
We can talk in more detail there.
PS. for me GY-271 work ok

regards,
Karol

@Bucknalla
Copy link
Contributor

@livius2 No worries! :) I'm happy to help you!

I would suggest creating a pull request from your fork from commits:
Create HMC5883L.py - 3283064
Create testCompass.py - 65537c9

This way you're only pushing what you have been working on. I've linked to the git documentation so you can see how to make a pull request with start and end commits!

https://git-scm.com/docs/git-request-pull

Thanks!

@livius2
Copy link
Contributor Author

livius2 commented May 3, 2017

I will look into git docs and back to you.
But may i ask what problem do you have with GY-271?

@livius2
Copy link
Contributor Author

livius2 commented May 5, 2017

S:\GITHUB\pycom-libraries [livius2-HMC5883L ?]> git request-pull -p 3283064b05b2
62e39a62098f8ca08c5f519100ae https://github.com/pycom/pycom-libraries.git 65537c
9724f14a0d92155f4c0bbe09bebf66d2f3
warn: No match for commit 65537c9724f14a0d92155f4c0bbe09bebf66d2f3 found at http
s://github.com/pycom/pycom-libraries.git
warn: Are you sure you pushed '65537c9724f14a0d92155f4c0bbe09bebf66d2f3' there?
The following changes since commit 3283064b05b262e39a62098f8ca08c5f519100ae:

Hi, i tried without any success. More hints about?

@livius2
Copy link
Contributor Author

livius2 commented May 5, 2017

done this differently
I have created new branch from pycom/master
then i have cherry-pick "this two commits"
push
and then i have created separate pull request #8

@livius2
Copy link
Contributor Author

livius2 commented May 5, 2017

I have added also separate pull for onewire #9
now this #6 can be closed as replaced by #8 and #9

@Bucknalla Bucknalla closed this May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants