ESP-NOW documentation and updating Coap documentation after esp-idf 4.1 update #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-pycom
suggested changes
Jan 21, 2021
geza-pycom
commented
Jan 22, 2021
|
@peter-pycom : just heads up that please do not merge this once we have discussed all the comments, I am not sure whether this is the correct branch to merge these updates. |
geza-pycom
changed the title
peter-pycom
previously approved these changes
Feb 10, 2021
peter-pycom
suggested changes
Feb 10, 2021
| @@ -158,13 +160,14 @@ Registers a callback function which will be called when a new resource has been | |||
| * `callback` is the callback to be registered. The callback must have 1 argument: | |||
| * `resource` is the new resource which has been created | |||
|
|
|||
| #### Coap.new_client_session(destination, port=5683, protocol=UDP) | |||
| #### Coap.new_client_session(address, *, port=5683, psk=None, identity=None) | |||
There was a problem hiding this comment.
new_client_session() has lost the protocol param, but remove_client_session() still has it. intentional?
There was a problem hiding this comment.
Yes it is.
When you call new_client_session() the Protocol is figured out based on the PSK and Identity parameters.
When you cal remove_client_session() it may happen that you have 2 Clients connected to the same Port, but one is using UDP the other is DTLS.
|
I think you guys agreed on a branch for this, right? Can you update the PR? |
|
New request opened towards correct branch: #387 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.