Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake support #73

Closed
wants to merge 15 commits into from
Closed

Add CMake support #73

wants to merge 15 commits into from

Commits on Feb 28, 2023

  1. Add CMake build 

    - Add CMakeLists.txt to build the native and wrapped proto caster libraries
- Use FetchContent to retrieve dependencies.
- Base dependencies on version from google/or-tools.
- Declare all fetch content dependencies before calling make available .
- Use CACHE INTERNAL to disable protobuf tests.
- Set dependency versions to match those in google/or-tools.

Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    5ad5713 View commit details
    Browse the repository at this point in the history

  2. Add CMake build 

    - Add warning message that CI testing is missing.

Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    4f6e5c9 View commit details
    Browse the repository at this point in the history

  3. Add CMake build 

    - Accept changes after running pre-commit.

Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a055cf1 View commit details
    Browse the repository at this point in the history

  4. Add CMake build 

    - Update cxx flags.
- Remove CI warning.

Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    c51c23b View commit details
    Browse the repository at this point in the history

  5. Add CMake build 

    - Add GHW workflow for build.

Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    78637ad View commit details
    Browse the repository at this point in the history

  6. Show more info about the build environment, separate cmake configure,… 

    … build steps (similar to what we have in pybind11/.github/workflows).
    Ralf W. Grosse-Kunstleve committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    d758885 View commit details
    Browse the repository at this point in the history

  7. Also show Python version

    Ralf W. Grosse-Kunstleve committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    950daac View commit details
    Browse the repository at this point in the history

  8. Add -DCMAKE_VERBOSE_MAKEFILE=ON

    Ralf W. Grosse-Kunstleve committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    cb379d1 View commit details
    Browse the repository at this point in the history

  9. Remove pull triggers.

    Ralf W. Grosse-Kunstleve committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    5b092ac View commit details
    Browse the repository at this point in the history

  10. Add back push branch main trigger in ubuntu-build.yml only (based on … 

    …comment by @mkruskal-google)
    Ralf W. Grosse-Kunstleve committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    2a4438e View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Improve portability when configuring for position independent code 

    Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    a3e1bff View commit details
    Browse the repository at this point in the history

  2. Remove redundant check for protobuf dependency 

    Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    e388b89 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Update dependency usage of find_package and FetchContent 

    - Move global dependency settings to top level CMakeLists.txt.
- Remove options to build dependencies.
- Add option to build tests (placeholder).
- Only FetchContent if find_package fails.

Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    44a9c21 View commit details
    Browse the repository at this point in the history

  2. Remove unused CMake file. 

    - Remove cmake file for tests as not complete nor integrated.

Signed-off-by: Rhys Mainwaring <[email protected]>
    @srmainwaring
    srmainwaring committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    6159ace View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Add back push: branches: - main in pre-commit.yml

    Ralf W. Grosse-Kunstleve committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7736642 View commit details
    Browse the repository at this point in the history