-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix wheel building #352
Conversation
CodSpeed Performance ReportMerging #352 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2116 2120 +4
=========================================
+ Hits 2116 2120 +4 ☔ View full report in Codecov by Sentry. |
.github/workflows/pypi.yml
Outdated
# - name: 🚢 Publish to PyPI | ||
# uses: pypa/gh-action-pypi-publish@release/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you upload here instead of have separate steep to collect all wheels anbd upload only if all platfrom buildt successfully?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplicity 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you may then upload to pypi broken release that was revealed during build wheel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, I'd call it a "partial" release. it is actually pretty easy to upload more wheels if only some of them fail to build. In any case, this whole thing is draft, and I'm actively working on it. Nothing you see here at the moment should be considered something I've thought hard about. please hang on a moment. I'll let you know when it's ready for review if you'd like to look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, short of uncommenting out the pypi publish step, i think this is now better. let me know if it's following all the best practices you would suggest
you can see the final working test in https://github.com/pyapp-kit/psygnal/actions/runs/13092786487/job/36531555427#step:4:71
CI/CD Workflow Updates:
.github/workflows/pypi.yml
: Reorganized the build and deployment steps, including renaming jobs, using a new action for building and inspecting Python packages, and consolidating the publish steps.Dependency Updates:
pyproject.toml
: Moved thedev
dependencies to theoptional-dependencies
section, updated thetest
dependencies with specific versions, and added new dependencies undertestqt
. [1] [2]Recursion Handling Improvements:
src/psygnal/_signal.py
: Introduced a fixed recursion limit of 300 to avoid segfaults in mypyc-compiled programs, added checks for recursion depth in theemit_fast
and_run_emit_loop
methods, and ensured the recursion depth is decremented in afinally
block. [1] [2] [3] [4]