Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add and fix copy operators #255

Merged
merged 5 commits into from
Jan 31, 2024
Merged

fix: add and fix copy operators #255

merged 5 commits into from
Jan 31, 2024

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Jan 25, 2024

closes #254

This PR fixes copy of EventedSet and add copy operator to EventedList and EventedDic.

@Czaki Czaki requested a review from tlambert03 January 25, 2024 20:37
Copy link

codspeed-hq bot commented Jan 25, 2024

CodSpeed Performance Report

Merging #255 will not alter performance

Comparing Czaki:fix_copy (b0c758e) with main (b0d2057)

Summary

✅ 66 untouched benchmarks

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0d2057) 99.89% compared to head (b0c758e) 99.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          22       22           
  Lines        1900     1902    +2     
=======================================
+ Hits         1898     1900    +2     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again

@tlambert03 tlambert03 merged commit cfd3e5b into pyapp-kit:main Jan 31, 2024
56 checks passed
@tlambert03 tlambert03 added the bug Something isn't working label Feb 16, 2024
@Czaki Czaki deleted the fix_copy branch February 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Copy operator of evented sets lead to sharing inner structures between copies
2 participants