Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note to self regarding cluster reassignment #1419

Merged
merged 2 commits into from
Jun 28, 2023
Merged

doc: add note to self regarding cluster reassignment #1419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f5d3bd
wip: re-assign training embedding to their original cluster
hbredin Jun 27, 2023
16e5628
fix: revert change and add note for future self
hbredin Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pyannote/audio/pipelines/clustering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,9 @@ def assign_embeddings(
else:
hard_clusters = np.argmax(soft_clusters, axis=2)

# TODO: add a flag to revert argmax for trainign subset
# hard_clusters[train_chunk_idx, train_speaker_idx] = train_clusters
# NOTE: train_embeddings might be reassigned to a different cluster
# in the process. based on experiments, this seems to lead to better
# results than sticking to the original assignment.

return hard_clusters, soft_clusters, centroids

Expand Down