Skip to content

Add the shader source code to the shader() example #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

villares
Copy link
Collaborator

Dear @hx2A,

I should have opened an issue... I know this might not be the correct way of fixing this, but I'll open the PR anyway as a way of not forgetting about it and losing the code I retrieved from the Processing examples, which is used on this documentation item (while in the middle of doing something else).

Feel free to close this and/or to instruct me on how to do it properly, and I'll try at some other time 😄
... we should probably be discussing this in an issue, sorry!

@hx2A
Copy link
Collaborator

hx2A commented Mar 25, 2025

This is a good idea, we should include the shader code. At a minimum it would make working wish shaders slightly less opaque.

How to include it though? A solution here should also be compatible with what I come up with for unit tests. (Eventually) there will be unit tests based on the example code.

@villares
Copy link
Collaborator Author

villares commented Mar 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants