chore: no lint false positives

Signed-off-by: pengyu <[email protected]>
py023 · Jan 4, 2024 · fd6e21d · fd6e21d
1 parent 3609aa2
commit fd6e21d
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/be/src/olap/rowset/segment_creator.cpp b/be/src/olap/rowset/segment_creator.cpp
@@ -206,7 +206,7 @@ Status SegmentFlusher::_expand_variant_to_subcolumns(vectorized::Block& block,
         VLOG_DEBUG << "dump rs schema: " << _context->tablet_schema->dump_structure();
     }
 
-    block.swap(flush_block);
+    block.swap(flush_block); // NOLINT(bugprone-use-after-move)
     VLOG_DEBUG << "dump block: " << block.dump_data();
     VLOG_DEBUG << "dump flush schema: " << flush_schema->dump_structure();
     return Status::OK();

diff --git a/be/src/service/backend_service.cpp b/be/src/service/backend_service.cpp
@@ -224,7 +224,7 @@ void _ingest_binlog(IngestBinlogArg* arg) {
     }
 
     // Step 5.2: check data capacity
-    uint64_t total_size = std::accumulate(segment_file_sizes.begin(), segment_file_sizes.end(), 0);
+    uint64_t total_size = std::accumulate(segment_file_sizes.begin(), segment_file_sizes.end(), 0); // NOLINT(bugprone-fold-init-type)
     if (!local_tablet->can_add_binlog(total_size)) {
         LOG(WARNING) << "failed to add binlog, no enough space, total_size=" << total_size
                      << ", tablet=" << local_tablet->tablet_id();

diff --git a/be/src/vec/common/hash_table/hash_table.h b/be/src/vec/common/hash_table/hash_table.h
@@ -639,10 +639,10 @@ class HashTable : private boost::noncopyable,
         std::swap(_need_partition, rhs._need_partition);
         std::swap(_partitioned_threshold, rhs._partitioned_threshold);
 
-        Hash::operator=(std::move(rhs));
-        Allocator::operator=(std::move(rhs));
-        Cell::State::operator=(std::move(rhs));
-        ZeroValueStorage<Cell::need_zero_value_storage, Cell>::operator=(std::move(rhs));
+        Hash::operator=(std::move(rhs)); // NOLINT(bugprone-use-after-move)
+        Allocator::operator=(std::move(rhs)); // NOLINT(bugprone-use-after-move)
+        Cell::State::operator=(std::move(rhs)); // NOLINT(bugprone-use-after-move)
+        ZeroValueStorage<Cell::need_zero_value_storage, Cell>::operator=(std::move(rhs)); // NOLINT(bugprone-use-after-move)
 
         return *this;
     }

diff --git a/be/src/vec/exec/format/orc/vorc_reader.cpp b/be/src/vec/exec/format/orc/vorc_reader.cpp
@@ -1917,7 +1917,7 @@ Status OrcReader::on_string_dicts_loaded(
                 auto data_type = slot_desc->get_data_type_ptr();
                 if (data_type->is_nullable()) {
                     temp_block.insert(
-                            {ColumnNullable::create(std::move(dict_value_column),
+                            {ColumnNullable::create(std::move(dict_value_column), // NOLINT(bugprone-use-after-move)
                                                     ColumnUInt8::create(dict_value_column_size, 0)),
                              std::make_shared<DataTypeNullable>(std::make_shared<DataTypeString>()),
                              ""});

diff --git a/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp b/be/src/vec/exec/format/parquet/vparquet_group_reader.cpp
@@ -800,7 +800,7 @@ Status RowGroupReader::_rewrite_dict_predicates() {
                 auto data_type = slot_desc->get_data_type_ptr();
                 if (data_type->is_nullable()) {
                     temp_block.insert(
-                            {ColumnNullable::create(std::move(dict_value_column),
+                            {ColumnNullable::create(std::move(dict_value_column), // NOLINT(bugprone-use-after-move)
                                                     ColumnUInt8::create(dict_value_column_size, 0)),
                              std::make_shared<DataTypeNullable>(std::make_shared<DataTypeString>()),
                              ""});

diff --git a/be/src/vec/exec/scan/new_olap_scan_node.cpp b/be/src/vec/exec/scan/new_olap_scan_node.cpp
@@ -662,7 +662,7 @@ Status NewOlapScanNode::_init_scanners(std::list<VScannerSPtr>* scanners) {
                 }
 
                 const auto max_add_seg_nums = rs_seg_count[rowset_idx] - segment_idx_to_scan;
-                auto& split = rs_splits.emplace_back();
+                auto& split = rs_splits.emplace_back(); // NOLINT(bugprone-use-after-move)
                 split.rs_reader = read_source.rs_splits[rowset_idx].rs_reader->clone();
 
                 // if segments assigned to current scanner are already more than the average count,

diff --git a/be/src/vec/functions/function.cpp b/be/src/vec/functions/function.cpp
@@ -71,7 +71,7 @@ ColumnPtr wrap_in_nullable(const ColumnPtr& src, const Block& block, const Colum
 
         if (auto* nullable = assert_cast<const ColumnNullable*>(elem.column.get())) {
             const ColumnPtr& null_map_column = nullable->get_null_map_column_ptr();
-            if (!result_null_map_column) {
+            if (!result_null_map_column) { // NOLINT(bugprone-use-after-move)
                 result_null_map_column = null_map_column->clone_resized(input_rows_count);
             } else {
                 if (!mutable_result_null_map_column) {