DOC: Improve two docstrings #2945
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecate_with_replacement and deprecate_no_replacement are not raising exceptions, but are issuing warnings. Change their docstrings to reflect this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 52 52
Lines 8749 8749
Branches 1591 1591
=======================================
Hits 8435 8435
Misses 186 186
Partials 128 128 ☔ View full report in Codecov by Sentry. |
stefan6419846
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecate_with_replacement and deprecate_no_replacement are not raising exceptions, but are issuing warnings. Change their docstrings to reflect this.