Fix locally running pyright fails #1012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyright is now smart enough to understand `sys.version_info` checks
|
pyright is not smart enough, it is just that uv decided to use 3.10 for local development... |
ItsDrike
requested changes
May 27, 2025
Comment on lines
22
to
26
| # Since pyright assumes lowest supported version, it would default to using tomli | ||
| # which we don't want, as it's only installed if on <3.11 and pyright usually runs | ||
| # on latest versions. For that reason, we include or TYPE_CHECKING in the condition. | ||
| if sys.version_info >= (3, 11) or TYPE_CHECKING: | ||
| if sys.version_info >= (3, 11): | ||
| from tomllib import load as toml_parse | ||
| else: | ||
| from tomli import load as toml_parse |
There was a problem hiding this comment.
This should do the trick.
# Since pyright assumes lowest supported version, it would default to the tomli import
# which might however be unrecognized, as it's only installed conditionally by uv
# based on the python version. For that reason, we define a custom signature for pyright.
if TYPE_CHECKING:
from typing import Any, BinaryIO
def foo(fp: BinaryIO, /) -> dict[str, Any]: ...
elif sys.version_info >= (3, 11):
from tomllib import load as toml_parse
else:
from tomli import load as toml_parse
PerchunPak
added a commit
that referenced
this pull request
May 31, 2025
This way uv knows what version of Python to use. Before, it used 3.10 for me which resulted in #1012
|
Closing in favour of #1016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.