Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on app load fail #2265

Open
wants to merge 17 commits into
base: _jsc
Choose a base branch
from
Open

fix crash on app load fail #2265

wants to merge 17 commits into from

Conversation

madanagopalt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #2265 into _jsc will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             _jsc    #2265      +/-   ##
==========================================
- Coverage   69.79%   69.70%   -0.10%     
==========================================
  Files         156      156              
  Lines       25622    25725     +103     
==========================================
+ Hits        17883    17931      +48     
- Misses       7739     7794      +55     
Impacted Files Coverage Δ
src/rtPromise.h 91.11% <100.00%> (+0.63%) ⬆️
src/rtScriptV8/rtScriptNode.cpp 85.40% <100.00%> (ø)
src/rtScriptJSC/rtJSCWrappers.cpp 0.59% <0.00%> (-0.03%) ⬇️
src/rtScriptJSC/rtScriptJSC.cpp 0.00% <0.00%> (ø)
src/rtScriptJSC/rtJSCBindings.cpp 0.00% <0.00%> (ø)
examples/pxScene2d/src/pxScene2d.cpp 74.25% <0.00%> (ø)
examples/pxScene2d/src/pxContextGL.cpp 77.81% <0.00%> (+0.06%) ⬆️
examples/pxScene2d/src/pxShaderResource.cpp 84.33% <0.00%> (+0.14%) ⬆️
src/rtHttpRequest.cpp 79.45% <0.00%> (+1.16%) ⬆️
examples/pxScene2d/src/pxImage.cpp 83.72% <0.00%> (+1.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2685ca1...1edde47. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants