Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor desktop notifications and add unit tests #2609

Closed
wants to merge 12 commits into from
Closed

Refactor desktop notifications and add unit tests #2609

wants to merge 12 commits into from

Commits on Sep 25, 2024

  1. hidapi: Completely remove dependency on gi 

    Related pwr-Solaar#2480
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9e6bd8b View commit details
    Browse the repository at this point in the history

  2. Clarify that fake hidpp is used 

    This module shouldn't be necessary on the long run. Remove pieces from
it whenever possible.
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f3ce935 View commit details
    Browse the repository at this point in the history

  3. Simplify setup with pathlib

    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e638250 View commit details
    Browse the repository at this point in the history

  4. Fix test coverage reporting 

    Related pwr-Solaar#1097
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7b4d93a View commit details
    Browse the repository at this point in the history

  5. Introduce test coverage threshold 

    Enforce a total coverage of 40% of the code.

Related pwr-Solaar#1097
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    37f4be1 View commit details
    Browse the repository at this point in the history

  6. Setup reports and upload codecov 

    Create coverage.xml, upload it to GitHub CI and visualize with codecov.

Setup instruction:
- Install codecov for project
  https://github.com/settings/installations/55029514
- Add CODECOV_TOKEN in the GitHub CI project secrets

Related pwr-Solaar#1097
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ef54d28 View commit details
    Browse the repository at this point in the history

  7. Add code coverage badge 

    Related pwr-Solaar#1097
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9e946a0 View commit details
    Browse the repository at this point in the history

  8. Rename lr/notify module to desktop_notifications 

    Related pwr-Solaar#2273
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    667ee3c View commit details
    Browse the repository at this point in the history

  9. Make lr/desktop_notifications testable 

    Introduce unit tests.

Related pwr-Solaar#2273
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9655f71 View commit details
    Browse the repository at this point in the history

  10. Rename ui/notify module to desktop notifications 

    Related pwr-Solaar#2273
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    51ee729 View commit details
    Browse the repository at this point in the history

  11. Make ui/desktop_notifications testable 

    Introduce unit tests.

Related pwr-Solaar#2273
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    662bcb4 View commit details
    Browse the repository at this point in the history

  12. settings_template: Prepare removal of desktop_notifications dependency 

    Related pwr-Solaar#2273
    @MattHag
    MattHag committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e41fd65 View commit details
    Browse the repository at this point in the history