-
Notifications
You must be signed in to change notification settings - Fork 165
feat: gh run rerun|cancel
#1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gh run rerun|cancel
#1000
Conversation
Thanks for the PR! Looks awesome! 🎉 How easy is it to make a |
You mean
|
Yeah, exactly. Would that be useful as well? |
I'm not convinced tbh, I'm struggling to see the use-case. The way I see it, the user flow would be something like this
So to me I dont really understand how the user would know that the workflow failed. There are multiple cases I guess
I dont mind implementing it, just personally I dont see what the user flow is EDITI guess there are other motivations for rerunning a workflow rather than failed workflow. e.g workflow_dispatch etc |
Okay so basically, I have added keybindings for |
Maybe |
@williambdean What do you think about merging this PR, which adds If we want
Not that hard to add but I think it merits some discussion about how the signature/syntax should be |
Yeah, let's wait on that then! Did you want to update the README still? |
Readme updated✅ |
Yeah, they seem unrelated. Let me take a look at the changes |
@williambdean It's good to go I think |
Great. Taking a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Thanks!
Issue: #449
Details buffer
Telescope
Keybindings Update
Added the following keybindings to buffer and telescope:
<C-o>
→ Rerun workflow<C-f>
→ Rerun failed workflow<C-x>
→ Cancel workflow