Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL improvement: submit/next/prev buttons on navbar #473

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

JensHouses
Copy link
Contributor

solving #105

  • The Dojo name is a link to the Dojo
  • The Module name is a link to the Module
  • Starting a new Challenge in the control panel updates the Highlighting of the module Page if open
  • Starting a new Challenge in the control panel updates the control panel
  • Starting a new Challange in the module page updates the control panel
  • if first or last challenge is reached the corresponding buttons gets invisible to keep the layout
  • you can submit the flag to the current challenge in the control panel
  • notifications are sticked to the top to overlay the menu

Starting containers and submitting flag works.
Still WIP
If there is no next or previous challenge the button gets invisible
If we use the control panel and the module page is open, the active challenge gets highlighted correctly.
Improved code a little bit
@zardus zardus self-requested a review July 23, 2024 19:15
Copy link
Contributor

@zardus zardus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AWESOME! So smooth to work through the chals. Thank you.

Just a few minor comments, and then I think we'll be ready to merge!!

dojo_plugin/pages/dojo.py Show resolved Hide resolved
dojo_theme/templates/components/navbar.html Show resolved Hide resolved
I moved the Control Panel to thr right and shrinked the other menu buttons in normal view.
@JensHouses JensHouses requested a review from zardus July 25, 2024 17:31
@zardus
Copy link
Contributor

zardus commented Jul 25, 2024

I'm about to take off on a flight and the internet is no good, so I can't pull this down to take a look locally, so we're going to just yolo it into production and take a look there!

Thank you for this contribution!! Huge QoL++

@zardus zardus merged commit 02359be into pwncollege:master Jul 25, 2024
1 check passed
@adamdoupe
Copy link
Contributor

@zardus this should not have been merged without fixing/addressing #478

The next button doesn't really work, and this is honestly more frustrating to use: because it is really very nice, you want it to work and it's a major bummer when it doesn't.

@JensHouses
Copy link
Contributor Author

@zardus this should not have been merged without fixing/addressing #478

The next button doesn't really work, and this is honestly more frustrating to use: because it is really very nice, you want it to work and it's a major bummer when it doesn't.

i added a PR to fix this #482

@zardus
Copy link
Contributor

zardus commented Jul 26, 2024

@zardus this should not have been merged without fixing/addressing #478

The next button doesn't really work, and this is honestly more frustrating to use: because it is really very nice, you want it to work and it's a major bummer when it doesn't.

But see, within 3 hours of yolo-merging, suddenly everything works perfectly ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants