-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes in the code and tests according to PR #455 related to utilization of the NetworkState class #469
base: RxJava2.x
Are you sure you want to change the base?
Conversation
ed161c8
to
eb37526
Compare
I also updated code of the sample apps. Unfortunately, In the Android emulator, network changes are not invoked for some reason. They're invoked only when I restart the Activity. On the |
Current analysis: Logic in |
…ccording to PR #455 related to utilization of the NetworkState class
eb37526
to
0dc63ee
Compare
…and added todo comments (2 tests are failing now)
I finally fixed handling state in the correct manner, so the last available connected network is propagated to the end of the stream if we lost connectivity with one network while being connected to two networks or more. Now a few more things needs to be done:
|
… may not be clear at the first look
…StrategyTest to compile and run other tests
fixes in the logic of MarshmallowNetworkObservingStrategy and tests according to PR #455 related to utilization of the NetworkState class