fix: remove pattern matching from location name

Location name should be a DNS label and could be matched by a regex. Correct one could be "^[a-zA-Z0-9]([a-zA-Z0-9\\-]*[a-zA-Z0-9])*$". PR podengo-project#21 has a discussion about it. But users can defined more values in IPA location in the FreeIPA server than what the RFCs allow. From this PoV, it is more important for idmsvc to pass registration even with slightly invalid DNS label than being valid but failing. Idmsvc doesn't use the value for DNS operations. Signed-off-by: Petr Vobornik <[email protected]>
pvoborni · Sep 27, 2024 · 1dec7c9 · 1dec7c9
1 parent 2ee029a
commit 1dec7c9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/public.openapi.json b/public.openapi.json
@@ -1373,7 +1373,6 @@
         "type": "string",
         "maxLength": 63,
         "minLength": 1,
-        "pattern": "^[a-z][a-z0-9\\-]*$",
         "x-rh-ipa-hcc": {
           "type": "defs"
         },

diff --git a/public.openapi.yaml b/public.openapi.yaml
@@ -974,12 +974,12 @@ components:
                 type: defs
             x-rh-rdn-value: name
         LocationName:
+            # validation pattern was removed to not be more restrictive than IPA server
             title: Location identifier (IPA location, AD site)
             description: A location identifier (lower-case DNS label)
             type: string
             maxLength: 63
             minLength: 1
-            pattern: ^[a-z][a-z0-9\-]*$
             x-rh-ipa-hcc:
                 type: defs
             example: alpha