Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct keys for FS modules in spectrum.spectral_factor_pvspec #2400

Merged
merged 4 commits into from
Feb 26, 2025
Merged

correct keys for FS modules in spectrum.spectral_factor_pvspec #2400

merged 4 commits into from
Feb 26, 2025

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Feb 25, 2025 •
edited
Loading

  • Closes PVSPEC model coefficients for First Solar modules use wrong keys #2398
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini changed the title correct keys correct keys for FS modules in spectrum.spectral_factor_pvspec Feb 25, 2025
@RDaxini RDaxini added this to the v0.11.3 milestone Feb 25, 2025
@RDaxini RDaxini marked this pull request as draft February 25, 2025 23:06
@RDaxini RDaxini marked this pull request as ready for review February 25, 2025 23:09
IoannisSifnaios
IoannisSifnaios approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@IoannisSifnaios IoannisSifnaios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit, maybe add the word "series" in the fs4-2 description:
image

@cwhanse cwhanse merged commit 5c86e8c into pvlib:main Feb 26, 2025
26 checks passed
@cwhanse
Copy link
Member

cwhanse commented Feb 26, 2025

Thanks @RDaxini

@RDaxini RDaxini deleted the pvspec_keys branch February 26, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhanse cwhanse cwhanse approved these changes

@IoannisSifnaios IoannisSifnaios IoannisSifnaios approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
v0.11.3
Development

Successfully merging this pull request may close these issues.

PVSPEC model coefficients for First Solar modules use wrong keys
3 participants
@RDaxini @cwhanse @IoannisSifnaios