Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include solarfactors in python 3.12 tests #2380

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

kandersolar
Copy link
Member

With the new solarfactors v1.6.0 release (and the shapely 2.0 compatibility it brings), it can be successfully installed and used on python 3.12 and above. That means we don't need to exclude it from the python 3.12 test environment anymore.

@kandersolar kandersolar added this to the v0.11.3 milestone Feb 7, 2025
Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kandersolar
Copy link
Member Author

Two reasons, I am guessing:

  1. Historical: a long time ago, in a pvlib version far far away, I think it was difficult/impossible to install some of the optional dependencies using only pip. And nobody has changed the test configuration since then.
  2. Still relevant today: if all of the tests are run with [optional] installed, then we don't have any check that pvlib works without [optional].

@kandersolar kandersolar merged commit 0507a3b into main Feb 12, 2025
27 checks passed
@kandersolar kandersolar deleted the kandersolar-patch-1 branch February 12, 2025 20:29
echedey-ls pushed a commit to echedey-ls/pvlib-python that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants