Skip to content

fix typo on calcparams_desoto help #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

EduardoSarquis
Copy link
Contributor

@EduardoSarquis EduardoSarquis commented Aug 22, 2024

There's a typo in the documentation of the "saturation_current" parameter on line 1553.

  • Closes Typo at pvlib.pvsystem.calcparams_desoto #2163
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

As part of the PVLib workshop at the PVPMC Workshop on Copenhagen, I learned how to contribute to PVLib with an simple example of fixing a typo.

There's a typo in the documentation of the "saturation_current" parameter on line 1553.
@EduardoSarquis
Copy link
Contributor Author

The contribution can be found here.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @EduardoSarquis !

@kandersolar kandersolar merged commit e2b1d9b into pvlib:main Aug 22, 2024
30 checks passed
@kandersolar kandersolar added this to the v0.11.1 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo at pvlib.pvsystem.calcparams_desoto
2 participants