Correct usage of xtol in ghi_from_poa_driesse_2023
#1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
reviewed
Feb 10, 2024
cwhanse
approved these changes
Feb 11, 2024
adriesse
requested changes
Feb 11, 2024
| Convergence criterion. The estimated GHI will be within xtol of the | ||
| true value. [W/m^2] | ||
| Convergence criterion. The estimated GHI will be within xtol of the | ||
| true value. Must be positive. [W/m^2] |
There was a problem hiding this comment.
Interestingly, the bisect docstring says nonnegative, which is inconsistent with its code.
| @@ -1599,7 +1603,7 @@ def ghi_from_poa_driesse_2023(surface_tilt, surface_azimuth, | |||
| solar_zenith, solar_azimuth, | |||
| poa_global, | |||
| dni_extra, airmass, albedo, | |||
| xtol=0.01) | |||
| xtol=xtol) | |||
Co-Authored-By: Anton Driesse <[email protected]>
kandersolar
changed the title
xtol in ghi_from_poa_driesse_2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xtolargument inghi_from_poa_driesse_2023#1970[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.I believe linked issue gives enough context.