-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pvlib.iotools.get_solrad
#1967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice with a "See Also" section in both the read and get function documentation.
Co-authored-by: Adam R. Jensen <[email protected]>
it is only available from pandas v1.4 onwards, so can't use it in pvlib yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Leaving this PR open for about a weeks time for anyone else to review
@AdamRJensen this PR is now updated to account for #1968. It also fixes an issue with #1968 where trying to Take a look and merge if it looks good to you? |
[ ] Closes #xxxxdocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.SOLRAD is a network of ground stations in the US similar to SURFRAD. SOLRAD data is available on the NOAA website in the form of daily files which pvlib-python can fetch and parse using
read_solrad
. However, this requires the user to construct each daily file URL manually and iteratively retrieve files, which is a minor annoyance.This PR creates a
get_solrad
function to wrap the existingread_solrad
function. It constructs the necessary filenames based on the supplied date range, iteratively callsread_solrad
, returns a single concatenated dataframe.