Feature/refactor formatter #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcinay055679
force-pushed
the
feature/refactor-formatter
branch
from
f97efba to
2ed2e36
Compare
Closed
2 tasks
kcinay055679
force-pushed
the
feature/refactor-formatter
branch
from
ea8bc1e to
47ecd0c
Compare
peggimann
requested changes
Sep 30, 2024
pizzi-cato
previously approved these changes
Oct 1, 2024
RandomTannenbaum
force-pushed
the
feature/refactor-formatter
branch
from
d93e6ea to
81f7113
Compare
MasterEvarior
requested changes
Oct 2, 2024
MasterEvarior
previously approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Looks good 👍
One thing that I think might be important is that as soon as this is merged, everybodies pre-commit hooks will stop working. It might be good idea to send a chat message to everybody informing them about that and what to do that they start working again
RandomTannenbaum
force-pushed
the
feature/refactor-formatter
branch
from
a674229 to
e029aa8
Compare
MasterEvarior
previously approved these changes
Oct 3, 2024
|
LGTM 😃 |
RandomTannenbaum
force-pushed
the
feature/refactor-formatter
branch
from
39f36f4 to
ebbf8f8
Compare
MasterEvarior
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.