Updated NPM packages and compatibility with Firefox #1
Conversation
| /********************************************* | ||
| * SLIDE MASTER | ||
| *********************************************/ | ||
|
|
||
| .reveal .slide-background { |
There was a problem hiding this comment.
Doesn't this add a background if no style is specified?
There was a problem hiding this comment.
Yes, actually - this will add a simple puzzle style (white background + puzzle tangrams) for slides without a master slide defined. Looks cool.
theme/source/puzzle.scss
Outdated
| // Primary/body text | ||
| $mainFont: 'Roboto', sans-serif; | ||
| $mainFont: 'Roboto', |
There was a problem hiding this comment.
This was because of the scss autoformatter. Sorry!
| @if $from==$to { | ||
| @return 'h#{$from}'; | ||
| } | ||
| @else { |
There was a problem hiding this comment.
Sorry this is from the scss autoformatter.
|
|
||
| // Override theme settings (see ../template/settings.scss) | ||
| // Background of the presentation | ||
| $backgroundColor: #fff; | ||
|
|
||
| $backgroundColor: #3B7BBE; |
There was a problem hiding this comment.
Why did you change this and then hardcode it in body?
There was a problem hiding this comment.
I thought it would be nice to have a general style. Without having to use a specific class - e.g. <!-- .slide: class="master01" -->
There was a problem hiding this comment.
Sounds reasonable. You didn't mention it in your description.
|
I reworked some changes and will resubmit another pull request soon! |
|
Why not just update this pull request? |
|
I'll have more improvements as I work on my workshop presentation. I guess I can update this pull request if you want |
|
@KeeTraxx Thanks for all your changes. Please comment when you are done, so I can review and merge. |
|
Ok, I guess it's ok for now. The major changes are:
|
Firefox needs escaping in data:image/svg+xml;utf8