Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run code analysis automatically via GitHub Action #350

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

khalwat
Copy link
Contributor

@khalwat khalwat commented Jan 31, 2024

Added a GitHub Action that will automatically run phpstan and ecs code quality tools on pushes to the develop branch.

This likely could easily be extended to run unit tests on pushes as well (see the notes in the .github/workflows/code-analysis.yaml file)

It should be a simple copy pasta to add this to your other plugins, but that's left as an exercise for the reader

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@khalwat
Copy link
Contributor Author

khalwat commented Feb 5, 2024

One thing I should have mentioned in this initial PR is that these inspections do not, and can not, alter the code in any way.

The repo is checked out in a container running in the cloud, the inspections are done there, and then the containers are discarded. Nothing is ever checked back in to the repository.

They are merely pass/fail tests that will be run on any PR or push, as an indicator to you that something is amiss.

@bencroker bencroker merged commit dfcc5d9 into putyourlightson:develop Feb 8, 2024
3 checks passed
@bencroker
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants