Fix trailing question mark

putyourlightson · Nov 7, 2024 · c05b921 · c05b921
1 parent b65c92e
commit c05b921
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/services/CacheRequestService.php b/src/services/CacheRequestService.php
@@ -418,13 +418,14 @@ public function getRequestedCacheableSiteUri(): ?SiteUriModel
             }
         }
 
+        $allowedQueryString = '';
         if (Blitz::$plugin->settings->queryStringCaching === SettingsModel::QUERY_STRINGS_DO_NOT_CACHE_URLS) {
-            $uri .= '?' . $queryString;
+            $allowedQueryString = $queryString;
         } elseif (Blitz::$plugin->settings->queryStringCaching === SettingsModel::QUERY_STRINGS_CACHE_URLS_AS_UNIQUE_PAGES) {
             $allowedQueryString = $this->getAllowedQueryString($site->id, '?' . $queryString);
-            if ($allowedQueryString) {
-                $uri .= '?' . $allowedQueryString;
-            }
+        }
+        if ($allowedQueryString) {
+            $uri .= '?' . $allowedQueryString;
         }
 
         return new SiteUriModel([