Skip to content

Commit

Permalink
Allow null value in priority
Browse files Browse the repository at this point in the history
  • Loading branch information
bencroker committed Jun 27, 2024
1 parent d46e893 commit b95943d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# Release Notes for Blitz

## 4.18.3 - Unreleased
## 4.18.3 - 2024-06-27

### Fixed

- Fixed an issue in which the priority of batch jobs could end up being a negative number.
- Fixed a bug in which the priority of refresh cache and driver jobs was interpreted as `0` when set to `null`.
- Fixed an issue in which the priority of batch jobs could be a negative number and therefore jobs would never complete.

## 4.18.2 - 2024-06-18

Expand Down
4 changes: 2 additions & 2 deletions src/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -248,13 +248,13 @@
// - `3`: Append "served by" comment only
//'outputComments' => true,

// The priority to give the refresh cache job (the lower the number, the higher the priority).
// The priority to give the refresh cache job (the lower the number, the higher the priority). If set to `null`, the default job priority will be used.
//'refreshCacheJobPriority' => 10,

//The batch size to use for driver jobs that support batching.
//'driverJobBatchSize' => 100,

// The priority to give driver jobs (the lower the number, the higher the priority).
// The priority to give driver jobs (the lower the number, the higher the priority). If set to `null`, the default job priority will be used.
//'driverJobPriority' => 100,

// The time to reserve for queue jobs in seconds.
Expand Down
8 changes: 4 additions & 4 deletions src/models/SettingsModel.php
Original file line number Diff line number Diff line change
Expand Up @@ -442,19 +442,19 @@ class SettingsModel extends Model
public int|bool $outputComments = true;

/**
* The priority to give the refresh cache job (the lower the number, the higher the priority).
* The priority to give the refresh cache job (the lower the number, the higher the priority). If set to `null`, the default job priority will be used.
*/
public int $refreshCacheJobPriority = 10;
public ?int $refreshCacheJobPriority = 10;

/**
* The batch size to use for driver jobs that support batching.
*/
public int $driverJobBatchSize = 100;

/**
* The priority to give driver jobs (the lower the number, the higher the priority).
* The priority to give driver jobs (the lower the number, the higher the priority). If set to `null`, the default job priority will be used.
*/
public int $driverJobPriority = 100;
public ?int $driverJobPriority = 100;

/**
* The time to reserve for queue jobs in seconds.
Expand Down

0 comments on commit b95943d

Please sign in to comment.