Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified list to include filter #1354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Jun 14, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In the file packages/restapi/src/lib/channels/getChannels.ts, the code looks good.

In the file packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts:

  1. There is a typo in the type definition NotifictaionType, it should be NotificationType.
  2. In the ChannelInfoOptions type definition, there is a missing closing curly brace '}'.
  3. In the UserSetting type definition, the 'enabled' field should be a required field.
  4. In the ChannelFeedsOptions type definition, there is a typo in the field name 'NotifictaionType', it should be 'NotificationType'.
  5. In the ChannelOptions type definition, the 'raw' field should be optional.
  6. In the ChannelListOptions type definition, there is a typo in the field name 'filter', it should be 'filter?'.

In the file packages/restapi/src/lib/pushNotification/channel.ts:

  1. There is a missing closing curly brace '}' at the end of the list method.
  2. In the notifications method, the 'raw' field should be optional.
  3. In the list method, there is a missing comma after 'filter'.

In the file packages/restapi/tests/lib/notification/channel.test.ts, there are multiple syntax errors and incomplete code blocks which need to be fixed.

Overall, there are some typos and syntax errors that need to be corrected in the types and methods definitions in the specified files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant