-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove open report getter #273
fix: remove open report getter #273
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see the get
pattern go away!
packages/cli/src/lib/commands/collect/utils/persist/open-report.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/commands/collect/utils/persist/open-report.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/commands/collect/utils/persist/open-report.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/commands/collect/utils/persist/open-report.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/lib/commands/collect/utils/persist/open-report.unit.test.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # package-lock.json # package.json
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…t-openReport # Conflicts: # package-lock.json # package.json
☕ Order Coffee ☕Date/Time: 2024-03-14 14:44
🔒 Budgets🧭 Navigate to coffee cartResource Size Budget
Resource Count Budget
Timing Budget
🧭 Navigate to githubResource Size Budget
Resource Count Budget
Timing Budget
|
❗❗❗ report generated by this PR ❗❗❗☕ Order Coffee ☕Date/Time: 2024-03-14 14:44
🔒 Budgets🧭 Navigate to coffee cartResource Size Budget
Resource Count Budget
Timing Budget
🧭 Navigate to githubResource Size Budget
Resource Count Budget
Timing Budget
|
TL;DR
Removes the
openReport
anddryRun
getters.Removes the use of the
interactive
get for the collect command implementation.Improves collect command typing.
Adds unit test for
open-report
Describe
This MR is the start of the elimination of option getter.
The motivation for this is described in this issue: #272
But in short it needs to happen to be able to migrate to ESM.
Additionally it removes the use of the
interactive
from the collect command implementation.To do so it required fixing the type of collect command which still requires further improvements as it should not require the use of
any
.Disclaimers
The collect command does not follow the same coding style as the inti command and uses a lot of promise chaining, This MR does not really help fix the code smell. In fact it makes it more complex.
We can deal with the issues related to that after the ESM migration.