Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten target params #36

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Shorten target params #36

merged 2 commits into from
Sep 24, 2024

Conversation

BioPhoton
Copy link
Contributor

@BioPhoton BioPhoton commented Sep 24, 2024

closes #19

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit d7e758e with source commit b1c5124.

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 57 🟡 57 ↓ +0
👍 2 audits improved, 👎 6 audits regressed, 2 audits changed without impacting score

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Nx Performance Checks [Task Time] cli-e2e:e2e 🟨 34.11 s 🟨 33.33 s ↓ −2 %
Nx Performance Checks [Task Time] core-e2e:e2e 🟨 30.96 s 🟨 31.45 s ↑ +2 %
Nx Performance Checks [Task Time] cli-e2e:build-env-env-setup 🟨 16.14 s 🟨 16.44 s ↑ +2 %
Nx Performance Checks [Task Time] models-e2e:e2e 🟨 10.55 s 🟨 10.73 s ↑ +2 %
Nx Performance Checks [Task Time] utils-e2e:e2e 🟨 12.24 s 🟨 12.42 s ↑ +1 %
Nx Performance Checks [Task Time] cli:build 🟩 5.54 s 🟩 5.62 s ↑ +1 %
Nx Performance Checks [Task Time] cli:unit-test 🟩 952 ms 🟩 962 ms ↑ +1 %
Nx Performance Checks [Graph Time] task graph 🟩 4.00 ms 🟩 3.96 ms ↓ −1 %
Nx Performance Checks [Task Time] cli-e2e-original:original-e2e 🟥 113.99 s 🟥 117.56 s ↑ +3 %
Nx Performance Checks [Graph Time] project graph 🟥 2814.99 ms 🟥 2859.36 ms ↑ +2 %

5 other audits are unchanged.

@BioPhoton BioPhoton merged commit 7cfb155 into main Sep 24, 2024
6 checks passed
@BioPhoton BioPhoton deleted the shorten-target-params branch November 8, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: rename environmentRoot to envRoot and environmentProject to envProject in all places
1 participant