Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
BioPhoton committed Oct 22, 2024
1 parent d94dd32 commit a938041
Show file tree
Hide file tree
Showing 12 changed files with 33 additions and 20 deletions.
16 changes: 15 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
"optionalDependencies": {
"@nx/nx-darwin-arm64": "^19.6.6",
"@nx/nx-darwin-x64": "^19.6.6",
"@nx/nx-linux-x64-gnu": "^19.6.6"
"@nx/nx-linux-x64-gnu": "^19.6.6",
"@rollup/rollup-linux-x64-gnu": "^4.24.0"
},
"nx": {
"includedScripts": []
Expand Down
7 changes: 6 additions & 1 deletion projects/nx-verdaccio/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@
"error",
{
"buildTargets": ["build"],
"ignoredDependencies": ["verdaccio"],
"ignoredDependencies": [
"verdaccio",
"nx",
"@code-pushup/models",
"@nx/plugin"
],
"checkMissingDependencies": true,
"checkObsoleteDependencies": true,
"checkVersionMismatches": true,
Expand Down
4 changes: 1 addition & 3 deletions projects/nx-verdaccio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@
"@nx/devkit": "19.8.0",
"ansis": "^3.3.2",
"simple-git": "^3.27.0",
"nx": "19.8.0",
"tslib": "^2.3.0",
"verdaccio": "*"
"tslib": "^2.3.0"
},
"type": "commonjs",
"main": "./src/index.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as bootstrapExecutorModule from './bootstrap-env';
import { PACKAGE_NAME } from '../../plugin/constants';
import { TARGET_ENVIRONMENT_VERDACCIO_STOP } from '../../plugin/targets/environment.targets';
import { MockAsyncIterableIterator } from '@push-based/test-utils';
import { ExecutorContext } from '@nx/devkit';
import { type ExecutorContext } from '@nx/devkit';

describe('runBootstrapExecutor', () => {
const e2eProjectName = 'my-lib-e2e';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@ import { bold, red } from 'ansis';
import { MEMFS_VOLUME } from '@push-based/test-utils';
import {
configureRegistry,
ConfigureRegistryOptions,
type ConfigureRegistryOptions,
setupNpmWorkspace,
unconfigureRegistry,
VERDACCIO_ENV_TOKEN,
} from './npm';
import { exec } from 'node:child_process';
import { logger } from '@nx/devkit';
import { formatInfo } from '../../internal/logging';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Environment } from './npm';
import { type Environment } from './npm';

export type BootstrapExecutorOptions = Partial<
{
Expand Down
1 change: 0 additions & 1 deletion projects/nx-verdaccio/src/executors/env-setup/executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
} from '../../plugin/targets/environment.targets';
import { runSingleExecutor } from '../../internal/run-executor';
import { rm } from 'node:fs/promises';
import { options } from 'yargs';
import { getEnvironmentRoot } from '../../internal/environment-root';

export type ExecutorOutput = {
Expand Down
2 changes: 1 addition & 1 deletion projects/nx-verdaccio/src/executors/env-setup/schema.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Environment } from '../env-bootstrap/npm';
import { type Environment } from '../env-bootstrap/npm';

export type SetupEnvironmentExecutorOptions = Partial<
Environment & {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export type TeardownEnvironmentOptions = Environment & { verbose?: boolean };

export async function teardownEnvironment(
context: ExecutorContext,
options: TeardownEnvironmentOptions,
git: SimpleGit = gitClient
options: TeardownEnvironmentOptions
): Promise<void> {
const environmentRoot = getEnvironmentRoot(context, options);
// kill verdaccio process if running
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import runKillProcessExecutor from './executor';
import * as killProcessModule from './kill-process';
import { MEMFS_VOLUME } from '@push-based/test-utils';
import { logger } from '@nx/devkit';
import { PACKAGE_NAME } from '../../plugin/constants';
import { EXECUTOR_ENVIRONMENT_KILL_PROCESS } from './constant';

vi.mock('@nx/devkit', async () => {
const actual = await vi.importActual('@nx/devkit');
Expand Down
8 changes: 4 additions & 4 deletions projects/nx-verdaccio/src/internal/environment-root.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { join } from 'node:path';
import { ExecutorContext } from '@nx/devkit';
import { ExpandedPluginConfiguration } from 'nx/src/config/nx-json';
import { NxVerdaccioCreateNodeOptions } from '../plugin/schema';
import { type ExecutorContext } from '@nx/devkit';
import { type ExpandedPluginConfiguration } from 'nx/src/config/nx-json';
import { type NxVerdaccioCreateNodeOptions } from '../plugin/schema';
import { DEFAULT_ENVIRONMENTS_OUTPUT_DIR } from '../plugin/constants';
import { Environment } from '../executors/env-bootstrap/npm';
import { type Environment } from '../executors/env-bootstrap/npm';

export function getEnvironmentDir(context: ExecutorContext) {
const plugin = context.nxJsonConfiguration?.plugins?.find((pCfg) => {
Expand Down

0 comments on commit a938041

Please sign in to comment.