cleanup

push-based · Sep 4, 2024 · 6ce8623 · 6ce8623
1 parent 616ab12
commit 6ce8623
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 68 deletions.
diff --git a/README.md b/README.md
@@ -8,6 +8,10 @@ This workspace maintains a scalable and maintainable E2E setup for Vite tests an
 
 ## Test it
 
+Publishable project have a `publishable` tag.
+Projects that need an environment have a `npm-env` tag.
+Targets that need an environment set up before running depend on `{ "projects": "self", "target": "setup-env", "params": "forward"}`.
+
 Production usage:
 
 - `nx run cli-e2e:e2e` - setup environment and then run E2E tests for `cli-e2e`

diff --git a/e2e/cli-e2e/project.json b/e2e/cli-e2e/project.json
@@ -3,26 +3,9 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "projects/cli-e2e/test",
   "projectType": "library",
-  "tags": [
-    "type:example",
-    "npm-env"
-  ],
-  "implicitDependencies": [
-    "cli"
-  ],
+  "tags": ["npm-env"],
+  "implicitDependencies": ["cli"],
   "targets": {
-    "build-env": {
-      "executor": "@org/build-env:build",
-      "options": {
-        "workspaceRoot": "tmp/cli-e2e"
-      }
-    },
-    "kill-process": {
-      "executor": "@org/build-env:kill-process",
-      "options": {
-        "workspaceRoot": "tmp/cli-e2e"
-      }
-    },
     "e2e": {
       "dependsOn": [
         {
@@ -32,13 +15,8 @@
         }
       ],
       "executor": "@nx/vite:test",
-      "inputs": [
-        "default",
-        "^production"
-      ],
-      "outputs": [
-        "{options.reportsDirectory}"
-      ],
+      "inputs": ["default", "^production"],
+      "outputs": ["{options.reportsDirectory}"],
       "options": {
         "reportsDirectory": "../../coverage/projects/cli-e2e"
       }

diff --git a/e2e/core-e2e/project.json b/e2e/core-e2e/project.json
@@ -3,13 +3,8 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "projects/core-e2e/test",
   "projectType": "library",
-  "tags": [
-    "type:example",
-    "npm-env"
-  ],
-  "implicitDependencies": [
-    "core"
-  ],
+  "tags": ["npm-env"],
+  "implicitDependencies": ["core"],
   "targets": {
     "e2e": {
       "dependsOn": [
@@ -20,13 +15,8 @@
         }
       ],
       "executor": "@nx/vite:test",
-      "inputs": [
-        "default",
-        "^production"
-      ],
-      "outputs": [
-        "{options.reportsDirectory}"
-      ],
+      "inputs": ["default", "^production"],
+      "outputs": ["{options.reportsDirectory}"],
       "options": {
         "reportsDirectory": "../../coverage/projects/core-e2e"
       }

diff --git a/e2e/models-e2e/project.json b/e2e/models-e2e/project.json
@@ -3,13 +3,8 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "projects/models-e2e/test",
   "projectType": "library",
-  "tags": [
-    "type:example",
-    "npm-env"
-  ],
-  "implicitDependencies": [
-    "models"
-  ],
+  "tags": ["npm-env"],
+  "implicitDependencies": ["models"],
   "targets": {
     "e2e": {
       "dependsOn": [
@@ -20,13 +15,8 @@
         }
       ],
       "executor": "@nx/vite:test",
-      "inputs": [
-        "default",
-        "^production"
-      ],
-      "outputs": [
-        "{options.reportsDirectory}"
-      ],
+      "inputs": ["default", "^production"],
+      "outputs": ["{options.reportsDirectory}"],
       "options": {
         "reportsDirectory": "../../coverage/projects/models-e2e"
       }

diff --git a/e2e/utils-e2e/project.json b/e2e/utils-e2e/project.json
@@ -3,13 +3,8 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "projects/utils-e2e/test",
   "projectType": "library",
-  "tags": [
-    "type:example",
-    "npm-env"
-  ],
-  "implicitDependencies": [
-    "utils"
-  ],
+  "tags": ["npm-env"],
+  "implicitDependencies": ["utils"],
   "targets": {
     "e2e": {
       "dependsOn": [
@@ -20,13 +15,8 @@
         }
       ],
       "executor": "@nx/vite:test",
-      "inputs": [
-        "default",
-        "^production"
-      ],
-      "outputs": [
-        "{options.reportsDirectory}"
-      ],
+      "inputs": ["default", "^production"],
+      "outputs": ["{options.reportsDirectory}"],
       "options": {
         "reportsDirectory": "../../coverage/projects/utils-e2e"
       }