Refactoring getcmsfields

[spekulatius]

No description provided.

[purplespider]

There was a reason I was using beforeUpdateCMSFields, but I'll need to remind myself what this was and get back to you!

[spekulatius]

Sure, no problem. I couldn't really figure out why, especially as it was the only place where I found this.

[spekulatius]

Have you had a chance to look into this @purplespider ?

[purplespider]

Hmm, just had a look at this. I use this module on many different websites, and on some of them I create a custom extension that modifies CalendarEntry, for example to add more fields or remove fields that aren't required for that particular site (such as Time).

So I'm pretty sure that it was added to allow me to do that. However, I've just had a play with some of my extensions and I've struggled to find one that was actually depending on beforeUpdateCMSFields. It seems it just does the same job as the $this->extend('updateCMSFields', $fields); hook, and that as long as at least one of those exists the extensions work as expected.

But looking at the module's history the updateCMSFields hook was added way before I added beforeUpdateCMSFields. So I'm still wondering why I felt the need to add it.