Prevent double cloning of git repos when fetching them in parallel #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fsoikin any idea what's up with windows here? The two fixtures are identical... |
|
I will take a look later (afk right now), but my first guess would be line breaks. |
fsoikin
reviewed
Sep 28, 2024
|
Yep, it's the newlines. They matter sometimes, but not always. I haven't figured out precisely when, but I suspect that the Purs output has platform-dependent newlines in it. That's why it worked before, but not after you added a build, and that's why it started working after you cut out the Purs output. I pushed a fix. I don't have a lot of time now, so I just added another |
Co-authored-by: Fyodor Soikin <[email protected]>
|
Ah yeah this all makes sense. Thanks @fsoikin for pushing the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1206: in #1275 we introduced a cache for git repos so we would not clone them more than once - however this didn't cover the case where we have a valid lockfile and we start with an empty
.spagofolder (such as the case of a fresh clone of a repo).This patch introduces a lock for git repos so we clone them only once even when multiple fibers are trying to clone them in parallel. We also add a test that reproduces the issue exactly, and behaves well with this patch.