Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

[WIP] Remove Eff in favor of Effect #141

Merged
merged 2 commits into from
May 8, 2018

Conversation

gabejohnson
Copy link

In furtherance of #93 I've swapped out Eff for Effect. Once this PR is merge (in the not too distant future 🙏) work can being on breaking the non-DOM related web APIs out into their own packages.

Everything builds, but there's a transitive dependency on Aff via https://github.com/bodil/purescript-test-unit.

Until Aff (and then Test.Unit) is updated to use Effect or a test library not reliant on Aff replaces it, a merge is not possible.

-> EventListener eff
:: forall a
. (Event -> Effect a)
-> EventListener
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're talking about related things on Slack just now, I remembered there's a breaking change I wanted to make here - eventListener should return in Effect, since it breaks referential transparency also.

@garyb
Copy link
Member

garyb commented May 8, 2018

Thanks for your work on this, I'll merge where it's at now, break out anything that isn't strictly dom-ish, and then make the 0.12 branch from what's left 👍

@garyb garyb merged commit aa2f317 into purescript-deprecated:effect May 8, 2018
@gabejohnson
Copy link
Author

I can still work on breaking things out if you'd like. I'm already working on purescript-web/purescript-web-storage#1 and purescript-web/purescript-web-socket#1

@gabejohnson gabejohnson deleted the eff->effect branch May 8, 2018 13:47
@garyb
Copy link
Member

garyb commented May 8, 2018

Ah, I've been doing those too 😄... I'm trying to work out a good way of breaking things up, so have been doing a lot of stuff locally. One thing that's happened so far is I've extracted specifically the DOM part of the the spec out as its own thing (purescript-web-dom) so we don't just end up having these packages pull in almost everything anyway.

I thing -web-dom has enough stuff in it for the other libraries too all work from, as it has important types like Node, Event, and EventTarget, so I think the HTML part of the spec will not be necessary as a requirement for this other stuff... will see how it goes anyway. I'm intending on having this somewhat usable today.

@gabejohnson
Copy link
Author

Sounds good! I'll halt on my PRs 😄

I'm trying to work out a good way of breaking things up

I'm putting together a straw man categorization of Web APIs. The idea is to have a plan for breaking things up now and extending with additional APIs later. I'll open an issue in this repo once it's ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants